[PATCH] D63628: AMD K10 (Barcelona) Initial Scheduler model

[Clement Courbet via Phabricator via llvm-commits]

courbet added a comment.

Amazing work Roman ! A few nits on the form, I'll let others more knowledgeable about AMD architectures comment on the model itself.



================
Comment at: include/llvm/TableGen/Record.h:1271
+                   << " with non-record type!\n";
+      assert(false && "FieldInit");
+    }
----------------
`llvm_unreachable` ?


================
Comment at: lib/Target/X86/X86ScheduleBarcelona.td:17
+//  * https://www.realworldtech.com/barcelona/
+//
+//===----------------------------------------------------------------------===//
----------------
`* Measurements from llvm-exegesis` ?


================
Comment at: lib/Target/X86/X86ScheduleBarcelona.td:760
+////////////////////////////////////////////////////////////////////////////////
+
+} // SchedModel
----------------
Does K10 have any zeroing/dependency breaking idioms ? Maybe add a FIXME to implement them.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63628/new/

https://reviews.llvm.org/D63628