[PATCH] D63280: [llvm-objdump] Use <first-symbol>-<offset> as the section start symbol
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 20 20:25:19 PDT 2019
MaskRay added a comment.
> Like @jhenderson suggested, I assume it does not sacrifice anything if we land this first, then revisit the issue later when GNU make the change also? This makes sure we are always consistent with GNU.
As I said, I don't know in what scenarios existing GNU objdump users cannot migrate to llvm-objdump just because of this incompatibility.
I am against the very idea of symbolizing an address with `<firstsym - offset>`. We all agree it is less ideal than `<.section>`, then I am not sure how this issue can be improved in the future. This patch would just create unnecessary churn if we later decide to change them back to `.plt`
- // DISASM-NEXT: 0000000000201020 .plt:
+ // DISASM-NEXT: 0000000000201020 bar2 at plt-0x10:
May I ask you to start a thread on https://lists.llvm.org/pipermail/llvm-dev/2019-June to discuss this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63280/new/
https://reviews.llvm.org/D63280
More information about the llvm-commits
mailing list