[PATCH] D63637: Do not set an RPATH on statically-linked LLVM executables.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 20 19:30:23 PDT 2019


chandlerc added reviewers: rnk, beanz.
chandlerc added a comment.

(Will likely need more eyes than just mine -- RPATH is mostly a mystery to me...)



================
Comment at: llvm/cmake/modules/AddLLVM.cmake:758
+    set(USE_SHARED USE_SHARED)
+    if(NOT ARG_NO_INSTALL_RPATH)
+      llvm_setup_rpath(${name})
----------------
Just to make sure I understand correctly, *any* time we build a shared library of some form, we'll get here? Even if its `libclang.so` or some such?

Provided I've understood correctly, then this make sense. However, I wonder, won't this still fail for things like c-index-test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63637/new/

https://reviews.llvm.org/D63637





More information about the llvm-commits mailing list