[PATCH] D63587: [AArch64][GlobalISel] Make s8 and s16 G_CONSTANTs legal

Thu Jun 20 17:22:04 PDT 2019

aemerson added a comment.

In D63587#1552523 <https://reviews.llvm.org/D63587#1552523>, @dsanders wrote:

> In D63587#1552333 <https://reviews.llvm.org/D63587#1552333>, @aemerson wrote:
>
> > In D63587#1552319 <https://reviews.llvm.org/D63587#1552319>, @arsenm wrote:
> >
> > > Should something like D56706 <https://reviews.llvm.org/D56706> go along with this?
> >
> >
> > Maybe?
> >
> > @dsanders Should we have a generic post legalizer combiner pass now?
>
>
> A generic post legalizer combiner is tricky because targets often want very different things. The plan is to have generic rules that target specific combiners can opt into in a reasonable way (e.g. by groups based on a generalized trait of the target) via the CombinerHelper

Alright, we'll keep it in the artifact combiner then.

@paquette this ok from the arm64 side?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63587/new/

https://reviews.llvm.org/D63587