[PATCH] D63629: [JumpThreading][PR42085] Do not fold conditional terminators of loop headers

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 20 15:49:55 PDT 2019


brzycki added a comment.

In D63629#1552868 <https://reviews.llvm.org/D63629#1552868>, @lebedev.ri wrote:

> > Folding conditional terminator instructions for basic blocks that are also loop headers can cause miscompiled code emitted from JumpThreading.
>
> Please can you write a more detailed explanation of the problem in the patch description.
>  "cause miscompiled code emitted" is vague.


I forgot to add https://bugs.llvm.org/show_bug.cgi?id=42085 which links to the deeper analysis. I'll fix the description.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63629/new/

https://reviews.llvm.org/D63629





More information about the llvm-commits mailing list