[PATCH] D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>

[Erich Keane via Phabricator via llvm-commits]

erichkeane marked 5 inline comments as done.
erichkeane added inline comments.


================
Comment at: llvm/test/TableGen/intrinsic-pointer-to-any.td:22
+class Intrinsic<list<LLVMType> ret_types,
+                list<LLVMType> param_types = [],
+                list<IntrinsicProperty> intr_properties = [],
----------------
greened wrote:
> Do we need this and the below parameters for the test?  AFAICT they are never passed.
They're not needed, though I was trying to just emulate what the actual definition of Intrinsic was.  I'll change it.


================
Comment at: llvm/test/TableGen/intrinsic-pointer-to-any.td:25
+                string name = ""> {
+  string LLVMName = name;
+  string TargetPrefix = "";   // Set to a prefix for target-specific intrinsics.
----------------
greened wrote:
> Are the members here expected to exist by `IntrinsicEmitter`?  If so, defaults could be set directly rather than using default arguments that are never passed.  If not, we could just delete them.
They all seem required.  I can do that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63507/new/

https://reviews.llvm.org/D63507