[PATCH] D63389: [IDF] Generalize IDFCalculator to be used with Clang's CFG

[Kristóf Umann via Phabricator via llvm-commits]

Szelethus updated this revision to Diff 205889.
Szelethus edited the summary of this revision.
Szelethus set the repository for this revision to rG LLVM Github Monorepo.
Szelethus added a comment.

Added a new type called `ChildrenGetterTy`, and added an instance of it as a field to `IDFCalculatorBase` (since we need to store a pointer to `GraphDiff` in it when specializing for `BasicBlock`).

Using template instantiations instead of runtime indirection.

> Why not have the generic base that used typical way of getting children with `children` (for clang) and a specialization for BasicBlock using GraphDiff?

That is what I was going for, it just took far too long to realize I didn't need to have that method be static :^)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63389/new/

https://reviews.llvm.org/D63389

Files:
  llvm/include/llvm/Analysis/IteratedDominanceFrontier.h
  llvm/include/llvm/Support/GenericIteratedDominanceFrontier.h
  llvm/lib/Analysis/CMakeLists.txt
  llvm/lib/Analysis/IteratedDominanceFrontier.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63389.205889.patch
Type: text/x-patch
Size: 18603 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190620/ab8a99d6/attachment.bin>