[PATCH] D62927: [sanitizers][windows] Rtl-Heap Interception and tests

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_malloc_win.cc:218
+    CHECK(dwFlags == 0 && "unsupported heap flags");
+  }
+  GET_CURRENT_PC_BP_SP;
----------------
mcgov wrote:
> vitalybuka wrote:
> > I'd expect this check is needed unconditionally, we can get to asan_malloc_usable_size even "if-then" about was executed.
> Oh good point, I'll check assertions again file-wide.
this is marked as done, but I don't see a difference.

I expected something like:
```
if (flags()->windows_hook_rtl_allocators) {
  ...
  REAL...
}
CHECK(dwFlags == 0 && "unsupported heap flags");
```

without else


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62927/new/

https://reviews.llvm.org/D62927