[PATCH] D63344: lld/elf: Deduplicate undefined symbol diagnostics

[Nico Weber via Phabricator via llvm-commits]

thakis marked an inline comment as done.
thakis added a comment.

Thanks!



================
Comment at: lld/ELF/Relocations.cpp:747
+  for (UndefinedDiag::Loc L : Undef.Locs) {
+    if (I >= MaxUndefReferences)
+      break;
----------------
ruiu wrote:
> nit: you can do `I++` here.
It's not quite the same: If the break is taken, `I` is incremented then, and it isn't currently. I could adjust for that in the if below, or start I at -1 (and change the init value at -1 and the type to int and add a cat to the if below), but everything I could think of so far is more complicated than what I currently have.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63344/new/

https://reviews.llvm.org/D63344