[PATCH] D63341: [llvm-lipo] Implement -thin

[Anusha Basana via Phabricator via llvm-commits]

anushabasana marked an inline comment as done.
anushabasana added a comment.

In D63341#1549652 <https://reviews.llvm.org/D63341#1549652>, @mtrent wrote:

> Would be nice if "llvm-lipo -thin" printed a reasonable error message before dumping usage. Apple lipo will print "missing argument to -thin option"
>
> Another difference is llvm-lipo will not validate the arch until all arguments are received, whereas Apple lipo will validate archs immediately. ("lipo -arch asdf")
>
> Would be nice if "llvm-lipo" printed a list of valid archs when the arch is invalid. Currently it prints "llvm-lipo: error: Invalid architecture: asdf" and it exits. Apple lipo prints "unknown architecture specification flag: asdf in specifying thin operation: -thin asdf. known architecture flags are: ..."
>
> PLEASE FIX: llvm-lipo does not support using "-o" in place of "-output"
>
> Note: "llvm-lipo" does not work properly with certain Mach-O executables, such as those built with the -hideARM64 flag.


Fixed most of these issues, but for printing a list of knows architectures I am planning to make a change in a separate diff that returns a list of valid architectures, since I will no longer be modifying llvm-lipo code.

For the MachO executables built with -hideARM64 flag, I filed a bug for MachOUniversalBinary: https://bugs.llvm.org/show_bug.cgi?id=42343.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63341/new/

https://reviews.llvm.org/D63341