[PATCH] D63220: [ELF][RISCV] Support GD/LD/IE/LE TLS models

[James Clarke via Phabricator via llvm-commits]

jrtc27 accepted this revision.
jrtc27 added a comment.
This revision is now accepted and ready to land.

One minor pedantic stylistic comment but otherwise this seems fine to me.



================
Comment at: ELF/Arch/RISCV.cpp:342
+  case R_RISCV_TLS_GOT_HI20:
+  case R_RISCV_TPREL_HI20: {
     uint64_t Hi = Val + 0x800;
----------------
This order is inconsistent with the LO12_[IS] variants. Personally I'd leave HI20/LO12_* as the final case statement before the block, and put the TLS/TPREL statements between PCREL and the plain HI20/LO12_*. This also has the benefit of reducing churn in the diff by not modifying existing lines unnecessarily.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63220/new/

https://reviews.llvm.org/D63220