[PATCH] D63565: [llvm-dwarfdump] Remove unnecessary explicit -h behaviour
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 20 07:41:20 PDT 2019
jhenderson added a comment.
In D63565#1551983 <https://reviews.llvm.org/D63565#1551983>, @hintonda wrote:
> LGTM, but you'll also want to fix `llvm/test/Support/check-default-options.txt`. It checks your special handling to make sure the default `-h` support didn't break it.
Thanks, I wasn't aware of that one (and hadn't yet bothered running every lit test for this). Just to be clear, are you recommending that I just delete the bits of that test relating to llvm-dwarfdump, since it will now follow the default process, or do you think there should be something else to replace it? I can replace it with llvm-opt-report, which seems to do something similar to llvm-dwarfdump.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63565/new/
https://reviews.llvm.org/D63565
More information about the llvm-commits
mailing list