[PATCH] D62997: [LV] Share the LV illegality reporting with LoopVectorize. NFC.
Pavel Samolysov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 20 07:10:10 PDT 2019
psamolysov updated this revision to Diff 205805.
psamolysov added a comment.
The diff has been updated: private methods were removed, the function 'reportVectorizationFailure' was moved to `LoopVectorize.cpp` and declared in `LoopVectorize.h` (namespace `llvm`). I've removed the `passName` parameter and pass `LV_NAME` as pass name to `ORE` but this change breaks 3 regression tests:
- Transforms/LoopVectorize/control-flow.ll
- Transforms/LoopVectorize/no_switch.ll
- Transforms/LoopVectorize/pr38800.ll
They all run `opt` with -pass-remarks-missed='loop-vectorize'
@rengolin @hsaito I need you suggestions how to deal with the `Hints.vectorizeAnalysisPassName()` method, it is very long to always call it whenever the `reportVectorizationFailure` is invoked.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62997/new/
https://reviews.llvm.org/D62997
Files:
llvm/include/llvm/Transforms/Vectorize/LoopVectorizationLegality.h
llvm/include/llvm/Transforms/Vectorize/LoopVectorize.h
llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp
llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
llvm/test/Transforms/LoopVectorize/nofloat-report.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62997.205805.patch
Type: text/x-patch
Size: 26970 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190620/ed83917b/attachment.bin>
More information about the llvm-commits
mailing list