[PATCH] D62676: [ARM] Add MVE vector compare instructions.

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:2267
+  bits<4> Qn;
+  bits<5> Rm;
+
----------------
Rm only needs 4 bits.


================
Comment at: llvm/test/MC/ARM/mve-vcmp.s:7
+# CHECK: vcmp.f16 eq, q0, q4  @ encoding: [0x31,0xfe,0x08,0x0f]
+# CHECK-NOFP-NOT: vcmp.f16 eq, q0, q4  @ encoding: [0x31,0xfe,0x08,0x0f]
+vcmp.f16 eq, q0, q4
----------------
We should also check the error message which is emitted in the NOFP case, and instructions with invalid conditions (the available conditions vary with type).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62676/new/

https://reviews.llvm.org/D62676