[PATCH] D60387: FileCheck [7/12]: Arbitrary long numeric expressions

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

I think I am happy with this, leaving the rest up to James.



================
Comment at: llvm/include/llvm/Support/FileCheck.h:158
+  /// using EvalBinop on the result of recursively evaluating the operands.
+  /// \returns an error if a numeric variable used is undefined, or the
+  /// expression value otherwise.
----------------
I prefer the description of the return value to give the expected/normal case first, and the error case afterward. So,
```
\returns the expression value, or an error ...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60387/new/

https://reviews.llvm.org/D60387