[PATCH] D63430: [ARM] Add support for the MVE long shift instructions

Sam Tebbs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 20 02:06:39 PDT 2019


samtebbs added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrInfo.td:181
 
+def ARMasrl          : SDNode<"ARMISD::ASRL", SDT_ARMIntShiftParts, [SDNPOutGlue]>;
+def ARMlsrl          : SDNode<"ARMISD::LSRL", SDT_ARMIntShiftParts, [SDNPOutGlue]>;
----------------
samparker wrote:
> Why do we have Glue flags here?
They were copied from existing patterns but I've verified that they are unnecessary so will remove.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63430/new/

https://reviews.llvm.org/D63430





More information about the llvm-commits mailing list