[PATCH] D63588: [llvm-nm] Generalize symbol types 'N' and 'n'

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 20 00:39:43 PDT 2019


grimar added inline comments.


================
Comment at: tools/llvm-nm/llvm-nm.cpp:915
-    if (!Name) {
-      consumeError(Name.takeError());
       return '?';
----------------
Shouldn't the new code fail with LLVM_ENABLE_ABI_BREAKING_CHECKS because of removing this line?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63588/new/

https://reviews.llvm.org/D63588





More information about the llvm-commits mailing list