[PATCH] D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer

[Seiya Nuta via Phabricator via llvm-commits]

seiya added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/MachO/Object.h:227
+
+  StringTableBuilder StrTableBuilder{StringTableBuilder::MachO};
 };
----------------
alexshap wrote:
> I'm wondering if MachOWriter would be a better place for StrTableBuilder ?
> MachOWriter::constructStringTable, MachOWriter::writeStringTable, MachOWriter::totalSize, MachOWriter::writeSymbolTable are the only users of this object, aren't they ? 
> 
You're correct! I'll fix this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63309/new/

https://reviews.llvm.org/D63309