[PATCH] D62964: [llvm-objdump] Match GNU objdump on symbol types shown in disassembly output.

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-disassemble-dynamic-symbols.test:24
 # STATIC-NEXT: 0000000000001002 only_static:
-# CHECK-NEXT:      1002:
+# STATIC-NEXT:     1002:
+# DYN-NEXT:    0000000000001003 func:
----------------
jhenderson wrote:
> This looks wrong, and I'm surprised this test isn't failing now. As things stand 0x1002 isn't being checked for at all in dynamic output, but there's no reason it shouldn't be there.
both_dyn is STT_OBJECT, dumped as data in one line until the next symbol regardless of its size.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62964/new/

https://reviews.llvm.org/D62964