[PATCH] D63560: AMDGPU: Treat undef as an inline immediate

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 19 14:24:23 PDT 2019


rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:497
                                            bool Negated) const {
-  // TODO: Handle undef
+  if (N->isUndef())
+    return true;
----------------
There is another use of isInlineImmediate (check case ISD::ConstantFP) around line 761. You will return true, but you do not initialize Imm with zero there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63560/new/

https://reviews.llvm.org/D63560





More information about the llvm-commits mailing list