[PATCH] D63558: AMDGPU: Undo sub x, c canonicalization for v2i16
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 19 14:18:42 PDT 2019
rampitec added inline comments.
================
Comment at: lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:93
+ uint32_t K = Negate ?
+ (-LHSVal & 0xffff) | (-RHSVal << 16) :
+ (LHSVal & 0xffff) | (RHSVal << 16);
----------------
Don't you have warnings doing negation on an uint? Making it int may be cleaner.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63558/new/
https://reviews.llvm.org/D63558
More information about the llvm-commits
mailing list