[llvm] r363877 - [LFTR] Stylistic cleanup as suggested in last review comment of D62939 [NFC]

[Philip Reames via llvm-commits]

Author: reames
Date: Wed Jun 19 13:45:57 2019
New Revision: 363877

URL: http://llvm.org/viewvc/llvm-project?rev=363877&view=rev
Log:
[LFTR] Stylistic cleanup as suggested in last review comment of D62939 [NFC]

(Resumbit of r363292 which was reverted along w/an earlier patch)


Modified:
    llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp?rev=363877&r1=363876&r2=363877&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp Wed Jun 19 13:45:57 2019
@@ -2388,12 +2388,15 @@ bool IndVarSimplify::
 linearFunctionTestReplace(Loop *L, BasicBlock *ExitingBB,
                           const SCEV *ExitCount,
                           PHINode *IndVar, SCEVExpander &Rewriter) {
+  assert(L->getLoopLatch() && "Loop no longer in simplified form?");
+  assert(isLoopCounter(IndVar, L, SE));
+  Instruction * const IncVar =
+    cast<Instruction>(IndVar->getIncomingValueForBlock(L->getLoopLatch()));
+
   // Initialize CmpIndVar and IVCount to their preincremented values.
   Value *CmpIndVar = IndVar;
   const SCEV *IVCount = ExitCount;
 
-  assert(L->getLoopLatch() && "Loop no longer in simplified form?");
-
   // If the exiting block is the same as the backedge block, we prefer to
   // compare against the post-incremented value, otherwise we must compare
   // against the preincremented value.
@@ -2404,14 +2407,12 @@ linearFunctionTestReplace(Loop *L, Basic
       // to add a potentially UB introducing use.  We need to either a) show
       // the loop test we're modifying is already in post-inc form, or b) show
       // that adding a use must not introduce UB.
-      Instruction *Inc =
-        cast<Instruction>(IndVar->getIncomingValueForBlock(L->getLoopLatch()));
       if (ICmpInst *LoopTest = getLoopTest(L, ExitingBB))
-        SafeToPostInc = LoopTest->getOperand(0) == Inc ||
-          LoopTest->getOperand(1) == Inc;
+        SafeToPostInc = LoopTest->getOperand(0) == IncVar ||
+          LoopTest->getOperand(1) == IncVar;
       if (!SafeToPostInc)
         SafeToPostInc =
-          mustExecuteUBIfPoisonOnPathTo(Inc, ExitingBB->getTerminator(), DT);
+          mustExecuteUBIfPoisonOnPathTo(IncVar, ExitingBB->getTerminator(), DT);
     }
     if (SafeToPostInc) {
       // Add one to the "backedge-taken" count to get the trip count.
@@ -2422,7 +2423,7 @@ linearFunctionTestReplace(Loop *L, Basic
       // The BackedgeTaken expression contains the number of times that the
       // backedge branches to the loop header.  This is one less than the
       // number of times the loop executes, so use the incremented indvar.
-      CmpIndVar = IndVar->getIncomingValueForBlock(ExitingBB);
+      CmpIndVar = IncVar;
     }
   }
 
@@ -2438,7 +2439,6 @@ linearFunctionTestReplace(Loop *L, Basic
   // dynamically dead IV that wraps on the first loop iteration only, which is
   // not covered by the post-inc addrec. (If the new IV was not dynamically
   // dead, it could not be poison on the first iteration in the first place.)
-  Value *IncVar = IndVar->getIncomingValueForBlock(L->getLoopLatch());
   if (auto *BO = dyn_cast<BinaryOperator>(IncVar)) {
     const SCEVAddRecExpr *AR = cast<SCEVAddRecExpr>(SE->getSCEV(IncVar));
     if (BO->hasNoUnsignedWrap())