[PATCH] D63393: [llvm-objdump] Remove unnecessary indentation when dumping ELF data.
Phabricator via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 19 11:41:14 PDT 2019
This revision was automatically updated to reflect the committed changes.
Closed by commit rL363858: [llvm-objdump] Remove unnecessary indentation when dumping ELF data. (authored by yuanfang, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D63393?vs=205348&id=205653#toc
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63393/new/
https://reviews.llvm.org/D63393
Files:
llvm/trunk/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s
llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
Index: llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
===================================================================
--- llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
+++ llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
@@ -996,10 +996,8 @@
int NumBytes = 0;
for (; Index < End; ++Index) {
- if (NumBytes == 0) {
+ if (NumBytes == 0)
outs() << format("%8" PRIx64 ":", SectionAddr + Index);
- outs() << "\t";
- }
Byte = Bytes.slice(Index)[0];
outs() << format(" %02x", Byte);
AsciiData[NumBytes] = isPrint(Byte) ? Byte : '.';
Index: llvm/trunk/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s
===================================================================
--- llvm/trunk/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s
+++ llvm/trunk/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s
@@ -1,4 +1,4 @@
-// RUN: llvm-mc %s -filetype=obj -triple=x86_64-pc-linux | llvm-objdump -d - | FileCheck %s
+// RUN: llvm-mc %s -filetype=obj -triple=x86_64-pc-linux | llvm-objdump -d - | FileCheck --strict-whitespace --match-full-lines %s
.text
.globl foo
.type foo, @function
@@ -14,6 +14,5 @@
bar:
.string "test string"
-// CHECK: b: 74 65 73 74 20 73 74 72 test str
-// CHECK-NEXT: 13: 69 6e 67 00 ing.
-
+// CHECK: b: 74 65 73 74 20 73 74 72 test str
+// CHECK-NEXT: 13: 69 6e 67 00 ing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63393.205653.patch
Type: text/x-patch
Size: 1482 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190619/85431dfb/attachment.bin>
More information about the llvm-commits
mailing list