[llvm] r363858 - [llvm-objdump] Remove unnecessary indentation when dumping ELF data.

Yuanfang Chen via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 19 11:44:29 PDT 2019


Author: yuanfang
Date: Wed Jun 19 11:44:29 2019
New Revision: 363858

URL: http://llvm.org/viewvc/llvm-project?rev=363858&view=rev
Log:
[llvm-objdump] Remove unnecessary indentation when dumping ELF data.

Reviewers: MaskRay, jhenderson, rupprecht

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D63393

Modified:
    llvm/trunk/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s
    llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp

Modified: llvm/trunk/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s?rev=363858&r1=363857&r2=363858&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s (original)
+++ llvm/trunk/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s Wed Jun 19 11:44:29 2019
@@ -1,4 +1,4 @@
-// RUN: llvm-mc %s -filetype=obj -triple=x86_64-pc-linux | llvm-objdump -d - | FileCheck %s
+// RUN: llvm-mc %s -filetype=obj -triple=x86_64-pc-linux | llvm-objdump -d - | FileCheck --strict-whitespace --match-full-lines %s
         .text
         .globl  foo
         .type   foo, @function
@@ -14,6 +14,5 @@ foo:
 bar:
         .string "test string"
 
-// CHECK:        b:        74 65 73 74 20 73 74 72         test str
-// CHECK-NEXT:  13:        69 6e 67 00                     ing.
-
+// CHECK:       b: 74 65 73 74 20 73 74 72         test str
+// CHECK-NEXT:      13: 69 6e 67 00                     ing.

Modified: llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp?rev=363858&r1=363857&r2=363858&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp (original)
+++ llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp Wed Jun 19 11:44:29 2019
@@ -996,10 +996,8 @@ static void dumpELFData(uint64_t Section
   int NumBytes = 0;
 
   for (; Index < End; ++Index) {
-    if (NumBytes == 0) {
+    if (NumBytes == 0)
       outs() << format("%8" PRIx64 ":", SectionAddr + Index);
-      outs() << "\t";
-    }
     Byte = Bytes.slice(Index)[0];
     outs() << format(" %02x", Byte);
     AsciiData[NumBytes] = isPrint(Byte) ? Byte : '.';




More information about the llvm-commits mailing list