[PATCH] D63556: [llvm-mca][docs] clarify how the quality of the perf report is affected by the quality of the scheduling models.
Andrea Di Biagio via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 19 08:57:32 PDT 2019
andreadb marked 2 inline comments as done.
andreadb added a comment.
Thanks for the reviews @lebedev.ri and @mattd
In D63556#1550415 <https://reviews.llvm.org/D63556#1550415>, @lebedev.ri wrote:
> Makes sense to me at least. Should this be cross-referenced somewhere else?
My opinion is that this doesn't need to be cross-referenced.
================
Comment at: docs/CommandGuide/llvm-mca.rst:46
+By design, the quality of the analysis conducted by :program:`llvm-mca` is
+inevitably affected by the quality of the models in LLVM.
+
----------------
mattd wrote:
> This reads nicely, but I suggest adding "scheduling" to be clearer about what models. "[...] is inevitably affected by the quality of the scheduling models in LLVM."
I will change it. Thanks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63556/new/
https://reviews.llvm.org/D63556
More information about the llvm-commits
mailing list