[compiler-rt] r363821 - Specify log level for CMake messages (less stderr)
Stefan Granitz via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 19 08:25:32 PDT 2019
Author: stefan.graenitz
Date: Wed Jun 19 08:25:32 2019
New Revision: 363821
URL: http://llvm.org/viewvc/llvm-project?rev=363821&view=rev
Log:
Specify log level for CMake messages (less stderr)
Summary:
Specify message levels in CMake. Prefer STATUS (stdout).
As the default message mode (i.e. level) is NOTICE in CMake, more then necessary messages get printed to stderr. Some tools, noticably ccmake treat this as an error and require additional confirmation and re-running CMake's configuration step.
This commit specifies a mode (either STATUS or WARNING or FATAL_ERROR) instead of the default.
* I used `csearch -f 'llvm-project/.+(CMakeLists\.txt|cmake)' -l 'message\("'` to find all locations.
* Reviewers were chosen by the most common authors of specific files. If there are more suitable reviewers for these CMake changes, please let me know.
Patch by: Christoph Siedentop
Reviewers: zturner, beanz, xiaobai, kbobyrev, lebedev.ri, sgraenitz
Reviewed By: sgraenitz
Subscribers: mgorny, lebedev.ri, #sanitizers, lldb-commits, llvm-commits
Tags: #sanitizers, #lldb, #llvm
Differential Revision: https://reviews.llvm.org/D63370
Modified:
compiler-rt/trunk/cmake/Modules/CompilerRTDarwinUtils.cmake
Modified: compiler-rt/trunk/cmake/Modules/CompilerRTDarwinUtils.cmake
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/cmake/Modules/CompilerRTDarwinUtils.cmake?rev=363821&r1=363820&r2=363821&view=diff
==============================================================================
--- compiler-rt/trunk/cmake/Modules/CompilerRTDarwinUtils.cmake (original)
+++ compiler-rt/trunk/cmake/Modules/CompilerRTDarwinUtils.cmake Wed Jun 19 08:25:32 2019
@@ -410,8 +410,8 @@ macro(darwin_add_embedded_builtin_librar
INCLUDE ${arch}_FUNCTIONS
${${arch}_SOURCES})
if(NOT ${arch}_filtered_sources)
- message("${arch}_SOURCES: ${${arch}_SOURCES}")
- message("${arch}_FUNCTIONS: ${${arch}_FUNCTIONS}")
+ message(WARNING "${arch}_SOURCES: ${${arch}_SOURCES}")
+ message(WARNING "${arch}_FUNCTIONS: ${${arch}_FUNCTIONS}")
message(FATAL_ERROR "Empty filtered sources!")
endif()
endforeach()
More information about the llvm-commits
mailing list