[PATCH] D63459: Loop Cache Analysis

[Ettore Tiotto via Phabricator via llvm-commits]

etiotto marked 2 inline comments as done.
etiotto added inline comments.


================
Comment at: llvm/include/llvm/Analysis/LoopCacheAnalysis.h:220
+  void sortLoopCosts() {
+    std::sort(LoopCosts.begin(), LoopCosts.end(),
+              [](const LoopCacheCostTy &A, const LoopCacheCostTy &B) {
----------------
xbolva00 wrote:
> llvm::sort
Yup agree, thanks for pointing this out.


================
Comment at: llvm/lib/Analysis/LoopCacheAnalysis.cpp:564
+      continue;
+    TripCountsProduct *= TC.second;
+  }
----------------
Meinersbur wrote:
> Would it be useful to make `CacheCostTy` an `int64_t`? At least with UBSan we could diagnose an overflow.
Ok.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63459/new/

https://reviews.llvm.org/D63459