[PATCH] D63348: [libFuzzer] Improve FuzzedDataProvider helper.

[Max Moroz via llvm-commits]

Hi Yvan,

Thanks for letting me know! I'll fix this soon, and sorry for the breakage.

On Wed, Jun 19, 2019 at 05:36 Yvan Roux <yvan.roux at linaro.org> wrote:

> Hi Max,
>
> This commit broke AArch64 bots, ninja check2 output is:
>
> [39/697] Generating
> FuzzedDataProviderTestObjects.FuzzedDataProviderUnittest.cpp.aarch64.o
> FAILED:
> projects/compiler-rt/lib/fuzzer/tests/FuzzedDataProviderTestObjects.FuzzedDataProviderUnittest.cpp.aarch64.o
> cd
> /home/buildslave/buildslave/clang-cmake-aarch64-full/stage2/projects/compiler-rt/lib/fuzzer/tests
> && /home/buildslave/buildslave/clang-cmake-aarch64-full/stage2/./bin/clang
> -mcpu=cortex-a57 -fPIC -fvisibility-inlines-hidden -Werror=date-time
> -Werror=unguarded-availability-new -std=c++11 -Wall -Wextra
> -Wno-unused-parameter -Wwrite-strings -Wcast-qual
> -Wmissing-field-initializers -pedantic -Wno-long-long
> -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type
> -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion
> -fdiagnostics-color -ffunction-sections -fdata-sections -Wall
> -std=c++11 -Wno-unused-parameter -Wno-unknown-warning-option
> -Wno-covered-switch-default -DGTEST_NO_LLVM_RAW_OSTREAM=1
> -DGTEST_HAS_RTTI=0
>
> -I/home/buildslave/buildslave/clang-cmake-aarch64-full/llvm/utils/unittest/googletest/include
>
> -I/home/buildslave/buildslave/clang-cmake-aarch64-full/llvm/utils/unittest/googletest
>
> -I/home/buildslave/buildslave/clang-cmake-aarch64-full/llvm/projects/compiler-rt/lib/fuzzer
> -fno-rtti -O2 -fvisibility=hidden -march=armv8-a -c -o
> FuzzedDataProviderTestObjects.FuzzedDataProviderUnittest.cpp.aarch64.o
>
> /home/buildslave/buildslave/clang-cmake-aarch64-full/llvm/projects/compiler-rt/lib/fuzzer/tests/FuzzedDataProviderUnittest.cpp
> In file included from
>
> /home/buildslave/buildslave/clang-cmake-aarch64-full/llvm/projects/compiler-rt/lib/fuzzer/tests/FuzzedDataProviderUnittest.cpp:9:
>
> /home/buildslave/buildslave/clang-cmake-aarch64-full/llvm/projects/compiler-rt/lib/fuzzer/utils/FuzzedDataProvider.h:226:5:
> error: static_assert failed due to requirement
> 'std::numeric_limits<char>::is_signed' "Destination type must be
> signed."
>     static_assert(std::numeric_limits<TS>::is_signed,
>     ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> /home/buildslave/buildslave/clang-cmake-aarch64-full/llvm/projects/compiler-rt/lib/fuzzer/utils/FuzzedDataProvider.h:126:19:
> note: in instantiation of function template specialization
> 'FuzzedDataProvider::ConvertUnsignedToSigned<char, unsigned char>'
> requested here
>       char next = ConvertUnsignedToSigned<char>(data_ptr_[0]);
>                   ^
> 1 error generated.
>
> logs are availabe here:
> http://lab.llvm.org:8011/waterfall?show=clang-cmake-aarch64-full
>
> Thanks,
> Yvan
>
> On Tue, 18 Jun 2019 at 22:26, Max Moroz via Phabricator via
> llvm-commits <llvm-commits at lists.llvm.org> wrote:
> >
> > This revision was automatically updated to reflect the committed changes.
> > Closed by commit rL363735: [libFuzzer] Improve FuzzedDataProvider
> helper. (authored by Dor1s, committed by ).
> >
> > Repository:
> >   rL LLVM
> >
> > CHANGES SINCE LAST ACTION
> >   https://reviews.llvm.org/D63348/new/
> >
> > https://reviews.llvm.org/D63348
> >
> > Files:
> >   compiler-rt/trunk/lib/fuzzer/tests/FuzzedDataProviderUnittest.cpp
> >   compiler-rt/trunk/lib/fuzzer/utils/FuzzedDataProvider.h
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-- 
Max
Sent from a phone
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190619/99bc8d77/attachment.html>