[PATCH] D63294: [Analysis] enhance FP library function prototype checking to match types with name suffix

Wed Jun 19 06:36:33 PDT 2019

spatel added a comment.

In D63294#1549185 <https://reviews.llvm.org/D63294#1549185>, @efriedma wrote:

> AVR intentionally makes the C type "double" a single-precision float ("float" in IR).  So we could fail to recognize "fabs" etc. on AVR with this patch, I think?

How do we test that? If that's a problem here, we might have an existing problem in clang because we convert to LLVM intrinsics in clang/lib/CodeGen using similar checks.

Note that this an extension of the existing checks, and we have seen bugs caused by matching libcall signatures too loosely:
rL258428 <https://reviews.llvm.org/rL258428>
D16198 <https://reviews.llvm.org/D16198> / rL258325 <https://reviews.llvm.org/rL258325>

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63294/new/

https://reviews.llvm.org/D63294