[PATCH] D62964: [llvm-objdump] Match GNU objdump on symbol types shown in disassembly output.

Wed Jun 19 03:59:34 PDT 2019

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-disassemble-dynamic-symbols.test:24
 # STATIC-NEXT: 0000000000001002 only_static:
-# CHECK-NEXT:      1002:
+# STATIC-NEXT:     1002:
+# DYN-NEXT:    0000000000001003 func:
----------------
This looks wrong, and I'm surprised this test isn't failing now. As things stand 0x1002 isn't being checked for at all in dynamic output, but there's no reason it shouldn't be there.

================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-disassemble-dynamic-symbols.test:72
 DynamicSymbols:
-  - Name:    only_dyn
+  - Name:    notype
     Value:   0x1000
----------------
You can reduce the diff by making this symbol the STT_FUNC one and the func symbol the STT_NOTYPE one.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62964/new/

https://reviews.llvm.org/D62964