[PATCH] D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2.

Wed Jun 19 02:08:10 PDT 2019

hans added a comment.

In D61242#1547365 <https://reviews.llvm.org/D61242#1547365>, @delcypher wrote:

> @juliehockett Sorry I completely dropped the ball here and forgot to land this. I've rebased and committed the change. @thakis I noticed I had a merge conflict with your change. Hopefully this hasn't broken anything for you.

I don't have context here, but this change caused Chromium's clang package to stop building, failing with:

[...]
CMake Error at /work/llvm.monorepo/compiler-rt/cmake/config-ix.cmake:179 (message):

  Unsupported architecture: i386

Call Stack (most recent call first):

  /work/llvm.monorepo/compiler-rt/cmake/config-ix.cmake:218 (get_target_flags_for_arch)
  /work/llvm.monorepo/compiler-rt/test/ubsan/CMakeLists.txt:116 (get_test_cflags_for_apple_platform)

See https://bugs.chromium.org/p/chromium/issues/detail?id=976593#c3 for the full cmake invocation and output.

I've reverted this in r363779 until it's more clear what's happening.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61242/new/

https://reviews.llvm.org/D61242