[PATCH] D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added a comment.

Regarding tests - even without computing the new layout - could we add a test which simply copies a .so and verifies that the output is the same ?



================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOReader.cpp:244
+  MachO::dysymtab_command DySymTab = MachOObj.getDysymtabLoadCommand();
+  for (uint32_t i = 0; i < DySymTab.nindirectsyms; i++)
+    O.IndirectSymTable.Symbols.push_back(
----------------
maybe  
   ++i 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63395/new/

https://reviews.llvm.org/D63395