[PATCH] D61493: AMDGPU/MC: Add .amdgpu_lds directive

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: include/llvm/BinaryFormat/ELF.h:1429
+enum {
+  SHN_AMDGPU_LDS = 0xff00, // Variable in LDS; symbol encoded like SHN_COMMON
+};
----------------
Is there a particular reason for this value?


================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:601-602
+  if (Machine == EM_AMDGPU) {
+    return Index == SHN_AMDGPU_LDS;
+  } else if (Machine == EM_HEXAGON) {
     switch (Index) {
----------------
No else after return


================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:630
   case SYMBOL_COMMON:
-  case SYMBOL_HEXAGON_SCOMMON:
+  case SYMBOL_HEXAGON_SCOMMON: // aliases SYMBOL_AMDGPU_LDS
   case SYMBOL_HEXAGON_SCOMMON_2:
----------------
This seems like a problem?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61493/new/

https://reviews.llvm.org/D61493