[PATCH] D63459: Loop Cache Analysis

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

How would a pass use this analysis? It computes a cost for the current IR, but there is nothing to compare it to unless the transformation pass emits the transformed loop nest next to the original pass such that the LoopCacheAnalysis can compute its cost.



================
Comment at: llvm/lib/Analysis/LoopCacheAnalysis.cpp:564
+      continue;
+    TripCountsProduct *= TC.second;
+  }
----------------
Would it be useful to make `CacheCostTy` an `int64_t`? At least with UBSan we could diagnose an overflow.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63459/new/

https://reviews.llvm.org/D63459