[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

[Anton Afanasyev via Phabricator via llvm-commits]

anton-afanasyev marked 2 inline comments as done.
anton-afanasyev added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:250-252
+      // Finish "Frontend" section starting inside clang::ParseAST()
+      if (llvm::timeTraceProfilerEnabled())
+        llvm::timeTraceProfilerEnd();
----------------
lebedev.ri wrote:
> anton-afanasyev wrote:
> > lebedev.ri wrote:
> > > I think i'm missing a point here.
> > > Why do we want to end `"Frontend"` section here,  exclude all this following diag/optremark/etc stuff?
> > The answer is below, we have `EmitBackendOutput()` there, calling Backend actions.
> So, because we don't want "backend" timer to be within "frontend" timer.
> Can you please add that as a comment here? :)
Ok, done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63325/new/

https://reviews.llvm.org/D63325