[llvm] r363746 - Print dylib load kind (weak, reexport, etc) in llvm-objdump -m -dylibs-used

[Michael Trent via llvm-commits]

Author: mtrent
Date: Tue Jun 18 15:20:10 2019
New Revision: 363746

URL: http://llvm.org/viewvc/llvm-project?rev=363746&view=rev
Log:
Print dylib load kind (weak, reexport, etc) in llvm-objdump -m -dylibs-used

Summary:
Historically llvm-objdump prints the path to a dylib as well as the
dylib's compatibility version and current version number. This change
extends this information by adding the kind of dylib load: weak,
reexport, etc.

rdar://51383512

Reviewers: pete, lhames

Reviewed By: pete

Subscribers: rupprecht, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D62866

Modified:
    llvm/trunk/test/tools/llvm-objdump/X86/macho-dylib.test
    llvm/trunk/tools/llvm-objdump/MachODump.cpp

Modified: llvm/trunk/test/tools/llvm-objdump/X86/macho-dylib.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/X86/macho-dylib.test?rev=363746&r1=363745&r2=363746&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-objdump/X86/macho-dylib.test (original)
+++ llvm/trunk/test/tools/llvm-objdump/X86/macho-dylib.test Tue Jun 18 15:20:10 2019
@@ -1,10 +1,13 @@
-RUN: llvm-objdump -m -dylibs-used %p/Inputs/hello.exe.macho-x86_64 | FileCheck %s -check-prefix=USED
-RUN: llvm-objdump -m -dylib-id %p/Inputs/dylibLoadKinds.macho-x86_64 | FileCheck %s -check-prefix=ID
-RUN: llvm-objdump -m -dylib-id -no-leading-headers %p/Inputs/dylibLoadKinds.macho-x86_64 | FileCheck %s -check-prefix=IDNOHEADERS
-
+RUN: llvm-objdump -m -dylibs-used %p/Inputs/dylibLoadKinds.macho-x86_64 | FileCheck %s -check-prefix=USED
+USED: /usr/lib/foo1.dylib (compatibility version 0.0.0, current version 0.0.0)
+USED: /usr/lib/foo2.dylib (compatibility version 0.0.0, current version 0.0.0, weak)
+USED: /usr/lib/foo3.dylib (compatibility version 0.0.0, current version 0.0.0, reexport)
+USED: /usr/lib/foo4.dylib (compatibility version 0.0.0, current version 0.0.0, lazy)
 USED: /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1197.1.1)
 
+RUN: llvm-objdump -m -dylib-id %p/Inputs/dylibLoadKinds.macho-x86_64 | FileCheck %s -check-prefix=ID
 ID: /usr/lib/foo.dylib
 
+RUN: llvm-objdump -m -dylib-id -no-leading-headers %p/Inputs/dylibLoadKinds.macho-x86_64 | FileCheck %s -check-prefix=IDNOHEADERS
 IDNOHEADERS-NOT: dylibLoadKinds.macho-x86_64:
 IDNOHEADERS: /usr/lib/foo.dylib

Modified: llvm/trunk/tools/llvm-objdump/MachODump.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/MachODump.cpp?rev=363746&r1=363745&r2=363746&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objdump/MachODump.cpp (original)
+++ llvm/trunk/tools/llvm-objdump/MachODump.cpp Tue Jun 18 15:20:10 2019
@@ -1206,7 +1206,16 @@ static void PrintDylibs(MachOObjectFile
           outs() << " current version "
                  << ((dl.dylib.current_version >> 16) & 0xffff) << "."
                  << ((dl.dylib.current_version >> 8) & 0xff) << "."
-                 << (dl.dylib.current_version & 0xff) << ")\n";
+                 << (dl.dylib.current_version & 0xff);
+          if (Load.C.cmd == MachO::LC_LOAD_WEAK_DYLIB)
+            outs() << ", weak";
+          if (Load.C.cmd == MachO::LC_REEXPORT_DYLIB)
+            outs() << ", reexport";
+          if (Load.C.cmd == MachO::LC_LOAD_UPWARD_DYLIB)
+            outs() << ", upward";
+          if (Load.C.cmd == MachO::LC_LAZY_LOAD_DYLIB)
+            outs() << ", lazy";
+          outs() << ")\n";
         }
       } else {
         outs() << "\tBad offset (" << dl.dylib.name << ") for name of ";