[PATCH] D63341: [llvm-lipo] Implement -thin

Tue Jun 18 15:06:45 PDT 2019

anushabasana marked an inline comment as done.
anushabasana added inline comments.

================
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:178
   SmallVector<OwningBinary<Binary>, 1> InputBinaries;
+  // TODO: Add compatibility for archive files
   for (StringRef InputFile : InputFiles) {
----------------
anushabasana wrote:
> mtrent wrote:
> > not really sure what the right protocol for this is in LLVM-land. Should you file a bug in some LLVM-specific bug tracker? Or maybe should you print a warning/error saying a format is not (yet) supported? 
> > 
> > I thought Archive files were SymbolicFiles and so they "should" be supported, but maybe you're using the wrong level of API? (I could be wrong ... just asking.)
> Added an error clarifying that archive files are not yet supported, but we will file a bug to implement this.
> We are focusing on object files in this primary implementation.
Bug 42310 - - llvm-lipo does not support archive files 
https://bugs.llvm.org/show_bug.cgi?id=42310 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63341/new/

https://reviews.llvm.org/D63341