[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

[John McCall via Phabricator via llvm-commits]

rjmccall added inline comments.


================
Comment at: include/llvm/IR/IntrinsicInst.h:235
+      ebStrict           ///< This corresponds to "fpexcept.strict".
     };
 
----------------
Is it okay that `ebUnspecified` and `ebInvalid` overlap here?


================
Comment at: include/llvm/IR/IntrinsicInst.h:245
+    static ExceptionBehavior StrToExceptionBehavior(StringRef);
+    static StringRef ExceptionBehaviorToStr(ExceptionBehavior);
+
----------------
You should document the behavior of the `StrTo...` functions when the string is unexpected and the `...ToStr` functions when the enum is invalid/unspecified.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53157/new/

https://reviews.llvm.org/D53157