[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

[Amy Huang via Phabricator via llvm-commits]

akhuang added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1145-1149
+    bool Deref = false;
+    if (VI.Expr) {
+      if (!VI.Expr->extractIfOffset(ExprOffset, Deref))
         continue;
+    }
----------------
rnk wrote:
> I see. I thought this code was using the stuff I added in `DbgVariableLocation::extractFromMachineInstruction`. Hm.
> 
> In practice, do you actually see DIExpression offsets here? I think maybe we should just special case a single DW_OP_deref expression, since that's what we get at O0.
That should work


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63361/new/

https://reviews.llvm.org/D63361