[PATCH] D63102: Fix some lit test ResourceWarnings on Windows

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 09:34:42 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL363700: Fix some lit test ResourceWarnings on Windows (authored by amccarth, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D63102?vs=203919&id=205376#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63102/new/

https://reviews.llvm.org/D63102

Files:
  llvm/trunk/utils/lit/lit/TestRunner.py


Index: llvm/trunk/utils/lit/lit/TestRunner.py
===================================================================
--- llvm/trunk/utils/lit/lit/TestRunner.py
+++ llvm/trunk/utils/lit/lit/TestRunner.py
@@ -991,6 +991,7 @@
     for i,f in stderrTempFiles:
         f.seek(0, 0)
         procData[i] = (procData[i][0], f.read())
+        f.close()
 
     exitCode = None
     for i,(out,err) in enumerate(procData):


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63102.205376.patch
Type: text/x-patch
Size: 412 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190618/76aba68c/attachment.bin>


More information about the llvm-commits mailing list