[PATCH] D60698: [ARM] add target arch definitions for 8.1-M and MVE.

[Miloš Stojanović via Phabricator via llvm-commits]

mstojanovic added inline comments.


================
Comment at: llvm/trunk/unittests/Support/TargetParserTest.cpp:578
 
   for (unsigned i = 0; i <= Extensions; i++)
     EXPECT_TRUE(i == 0 ? !ARM::getExtensionFeatures(i, Features)
----------------
With this addition the test runs out of memory on a MIPS board. Shouldn't this loop go through each flag in the `Extensions` set or at least through every combination of the flags. It seems like overkill to loop from 0 to 16916342 and push mostly the same elements into the vector each time. Even it the platform doesn't run out of memory the test will be unnecessarily slow.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60698/new/

https://reviews.llvm.org/D60698