[PATCH] D62964: [llvm-objdump] Match GNU objdump on symbol types shown in disassembly output.

[Yuanfang Chen via Phabricator via llvm-commits]

ychen marked 4 inline comments as done.
ychen added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-disassemble-dynamic-symbols.test:63
     Binding: STB_GLOBAL
-  - Name:    both_dyn
     Value:   0x1001
----------------
jhenderson wrote:
> I think you may have gone overboard with the symbol renaming. These first two are deliberately named so that they clearly clash/don't clash with a corresponding static symbol (only_[static|dyn] means only the static/dynamic symbol respectively is present at that address whilst the both_[static|dyn] means both symbols have that value).
Thank you. Now I see the point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62964/new/

https://reviews.llvm.org/D62964