[PATCH] D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame.
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 18 09:00:42 PDT 2019
probinson added a comment.
The dwarfdump changes look okay, but the new tests don't exercise those changes. The simplest thing is probably to RUN llvm-dwarfdump in relax-debug-frame.ll and verify the output describes the frame as expected.
================
Comment at: lib/MC/MCDwarf.cpp:1907
+ if (Offset != nullptr && Size != nullptr)
+ WithFixups = true;
+
----------------
`bool WithFixups = (Offset != nullptr && Size != nullptr);`
or even just `(Offset && Size)`
================
Comment at: test/DebugInfo/RISCV/relax-debug-frame.ll:8
+; RELAX: R_RISCV_SET6
+; RELAX: R_RISCV_SUB6
+source_filename = "frame.c"
----------------
Do you have a way to prove these relocations are in the right section? Right now the test verifies that they come after the start of the .rela.*_frame section, but it does not verify they come before the end of the section.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58335/new/
https://reviews.llvm.org/D58335
More information about the llvm-commits
mailing list