[PATCH] D63492: [ARM] Rename MVE instructions in Tablegen for consistency.
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 18 06:50:40 PDT 2019
dmgreen added a comment.
I like the consistency this gives. Especially at immediately identifying MVE vs Neon instructions. What about the couple of places pointed out below?
================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:476
+defm VMLADAVs8 : MVE_VMLADAV_multi<"s8", 0b0, 0b0, 0b1>;
+defm VMLADAVu8 : MVE_VMLADAV_multi<"u8", 0b0, 0b1, 0b1>;
----------------
These six?
================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:575
+defm VMLALDAVu16 : MVE_VMLALDAV_multi<"u16", 0b0, 0b1>;
+defm VMLALDAVu32 : MVE_VMLALDAV_multi<"u32", 0b1, 0b1>;
----------------
These four?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63492/new/
https://reviews.llvm.org/D63492
More information about the llvm-commits
mailing list