[PATCH] D63475: [llvm-readobj] Allow --hex-dump/--string-dump to dump multiple sections

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: tools/llvm-readobj/ObjDumper.cpp:53
+    StringRef SecName;
+    error(SecRef.getName(SecName));
+    auto NameIt = SecNames.find(SecName);
----------------
Interesting. I was not expecting `error()` to do nothing if passed a success! I don't mind this being left as is, but there is precedent elsewhere in this file to do:

```
if (...)
  error(...);
```

See `printSectionsAsString` for such an example.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63475/new/

https://reviews.llvm.org/D63475