[PATCH] D63344: lld/elf: Deduplicate undefined symbol diagnostics

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 06:36:06 PDT 2019


grimar added a comment.

In D63344#1548225 <https://reviews.llvm.org/D63344#1548225>, @thakis wrote:

> grimar, should I keep the current version with the predicate, or the version with the IsWarning flag? I don't have a strong preference.


My opinion is that original version was slightly simpler, so I would return to using `IsWarning` flag probably. Unless there is a better way to use predicates.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63344/new/

https://reviews.llvm.org/D63344





More information about the llvm-commits mailing list