[PATCH] D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries

[James Henderson via Phabricator via llvm-commits]

jhenderson added a subscriber: mtrent.
jhenderson added a comment.

I've subscribed @mtrent, who I believe is Mach-O experienced (sorry if I'm wrong!). He might be able to assist with the review more.



================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp:60
 
-  MachOWriter Writer(*O, In.is64Bit(), In.isLittleEndian(), Out);
+  // TODO: Support 16KB pages which employed in iOS arm64 binaries:
+  //       https://github.com/llvm/llvm-project/commit/1bebb2832ee312d3b0316dacff457a7a29435edb
----------------
which employed -> which are employed

(I think)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63395/new/

https://reviews.llvm.org/D63395