[PATCH] D63475: [llvm-readobj] Allow --hex-dump/--string-dump to dump multiple sections

Tue Jun 18 03:15:12 PDT 2019

jhenderson requested changes to this revision.
jhenderson added a comment.
This revision now requires changes to proceed.

Not really looked at the code yet, but I noticed a problem with the test, which I'd like addressing.

================
Comment at: test/tools/llvm-readobj/hex-dump-multi.s:1
+# REQUIRES: x86-registered-target
+# RUN: llvm-mc -filetype=obj -triple x86_64 %s -o %t.o
----------------
Nit: I'd find it slightly easier to read if this had a blank line after.

================
Comment at: test/tools/llvm-readobj/hex-dump.test:1
+# RUN: llvm-readelf -S %p/Inputs/trivial.obj.elf-x86-64 | FileCheck %s --check-prefix=ELF-SEC
+
----------------
There is already a "hexdump.test" file. The additional test cases you are adding should be added to that (or that should be deleted/renamed to hex-dump.test).

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63475/new/

https://reviews.llvm.org/D63475