[PATCH] D63475: [llvm-readobj] Allow --hex-dump/--string-dump to dump multiple sections
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 18 02:00:27 PDT 2019
grimar added inline comments.
================
Comment at: tools/llvm-readobj/ObjDumper.cpp:40
+ std::vector<object::SectionRef> Ret;
+ StringMap<bool> SecNames;
+ std::unordered_map<int, bool> SecIndices;
----------------
grimar wrote:
> Map of `bool` is the same as `set` I think. Can you use `StringSet` instead of `StringMap<bool>`?
Oh, I misread the code. Please ignore this comment.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63475/new/
https://reviews.llvm.org/D63475
More information about the llvm-commits
mailing list