[PATCH] D63344: lld/elf: Deduplicate undefined symbol diagnostics

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 01:41:35 PDT 2019


MaskRay added inline comments.


================
Comment at: lld/test/ELF/undef-multi.s:4
+# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %p/Inputs/undef.s -o %t2.o
+# RUN: not ld.lld %t.o %t2.o -o %t.exe 2>&1 | FileCheck %s
+
----------------
`%t.exe -> /dev/null` if you don't need the output.


================
Comment at: lld/test/ELF/undef-multi.s:17
+
+# All references to a single undefined symbol count as a single error -- but
+# at most 10 references are printed.
----------------
Just a suggestion. It is now common to use `## ` for comments that are not RUN/CHECK lines. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63344/new/

https://reviews.llvm.org/D63344





More information about the llvm-commits mailing list